Remove losetup workaround in minikube VM #1840

nixpanic · 2021-01-22T16:05:14Z

Describe what this PR does

Currently the losetup executable is copied into the minikube VM because the version of losetup inside the VM does not support the -j option which is required for BlockMode volumes.

Related issues

See-also: kubernetes/minikube#8284 and kubernetes/minikube#10255

Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

/retest ci/centos/<job-name>: retest the <job-name> after unrelated
failure (please report the failure too!)
/retest all: run this in case the CentOS CI failed to start/report any test
progress or results

nixpanic · 2021-01-22T16:47:48Z

FWIW, the minikube.iso that is used for testing has been built with this change.

nixpanic · 2021-01-28T13:03:39Z

kubernetes/minikube#10255 has been merged, we'll have to wait for a minikube release that includes it before this PR can get moved out of draft.

nixpanic · 2021-02-01T08:15:10Z

https://github.com/kubernetes/minikube/tree/v1.17.1 has been released and adds losetup from util-linux. The workaround is not needed anymore. This PR can get merged once #1811 is included.

Madhu-1 · 2021-02-10T15:54:33Z

scripts/minikube.sh

@@ -130,17 +130,6 @@ function disable_storage_addons() {
    ${minikube} addons disable storage-provisioner 2>/dev/null || true
 }

-# minikube has the Busybox losetup, and that does not work with raw-block PVCs.


removing this one will cause any issue for the one who is using an older minikube version?

nixpanic · 2021-02-10T16:20:56Z

On Wed, Feb 10, 2021 at 07:54:50AM -0800, Madhu Rajanna wrote: @Madhu-1 commented on this pull request. > @@ -130,17 +130,6 @@ function disable_storage_addons() { ${minikube} addons disable storage-provisioner 2>/dev/null || true } -# minikube has the Busybox losetup, and that does not work with raw-block PVCs. removing this one will cause any issue for the one who is using an older minikube version?

Yes. But unfortunately we do not keep track of versions of dependencies we have for testing, so I think that is ok.

Madhu-1 · 2021-02-10T16:24:08Z

On Wed, Feb 10, 2021 at 07:54:50AM -0800, Madhu Rajanna wrote: @Madhu-1 commented on this pull request. > @@ -130,17 +130,6 @@ function disable_storage_addons() { ${minikube} addons disable storage-provisioner 2>/dev/null || true } -# minikube has the Busybox losetup, and that does not work with raw-block PVCs. removing this one will cause any issue for the one who is using an older minikube version?
Yes. But unfortunately we do not keep track of versions of dependencies we have for testing, so I think that is ok.

if we keep the current workaround for losetup it will it causes any issues for people who are using 1.17.1+?

nixpanic · 2021-02-10T16:29:34Z

if we keep the current workaround for losetup it will it causes any issues for people who are using 1.17.1+?

Possibly. There is no guarantee that the binary from the host works on the guest. We are just lucky it does. If anyone runs the setup script on a different Linux distribution, or on an other architecture, there is a big chance things will break.

nixpanic · 2021-02-11T10:14:15Z

It seems the minikube iso has not been updated? kubernetes/minikube#10444 has been filed to track it.

nixpanic · 2021-02-11T13:41:09Z

It seems the minikube iso has not been updated? kubernetes/minikube#10444 has been filed to track it.

Minor minikube versions mostly do not provide a new iso image. We'll have to wait until minikube 1.18.0 to get this merged.

Madhu-1 · 2021-02-11T13:45:00Z

It seems the minikube iso has not been updated? kubernetes/minikube#10444 has been filed to track it.

Minor minikube versions mostly do not provide a new iso image. We'll have to wait until minikube 1.18.0 to get this merged.

adding DNM till we get minikube major release

Minikube v1.18 has been released. This conains a fix for our `losetup` workaround, so that can be removed now. Updates: ceph#1840 Signed-off-by: Niels de Vos <ndevos@redhat.com>

Minikube v1.18 has been released. This conains a fix for our `losetup` workaround, so that can be removed now. Updates: #1840 Signed-off-by: Niels de Vos <ndevos@redhat.com>

nixpanic · 2021-03-03T10:49:39Z

Deploying Rook failed with:

  Normal   BackOff    24s (x2 over 48s)  kubelet            Back-off pulling image "docker.io/ceph/ceph:v14.2.12"
  Warning  Failed     24s (x2 over 48s)  kubelet            Error: ImagePullBackOff
  Normal   Pulling    9s (x3 over 49s)   kubelet            Pulling image "docker.io/ceph/ceph:v14.2.12"
  Warning  Failed     9s (x3 over 49s)   kubelet            Failed to pull image "docker.io/ceph/ceph:v14.2.12": rpc error: code = Unknown desc = Error response from daemon: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit

Need to pull the ceph image from the local CI mirror into the minikube VM.

nixpanic · 2021-03-03T10:51:29Z

Tests can be re-run after #1903 had been merged

nixpanic · 2021-03-03T11:53:07Z

/retest all

nixpanic · 2021-03-03T13:36:17Z

Even with minikube v1.18.0 the CI jobs fail with

Mar  3 12:45:09.791: INFO: At 2021-03-03 12:35:13 +0000 GMT - event for pod-with-raw-block-volume: {kubelet minikube} FailedMapVolume: MapVolume.MapBlockVolume failed for volume "pvc-c253a4c4-9fea-4de1-99cc-787d28f0c6c4" : blkUtil.AttachFileDevice failed. globalMapPath:/var/lib/kubelet/plugins/kubernetes.io/csi/volumeDevices/pvc-c253a4c4-9fea-4de1-99cc-787d28f0c6c4/dev, podUID: 5671604c-d8e5-4cc9-897f-a8012c635340: GetLoopDevice failed for path /var/lib/kubelet/plugins/kubernetes.io/csi/volumeDevices/pvc-c253a4c4-9fea-4de1-99cc-787d28f0c6c4/dev/5671604c-d8e5-4cc9-897f-a8012c635340: losetup -j /var/lib/kubelet/plugins/kubernetes.io/csi/volumeDevices/pvc-c253a4c4-9fea-4de1-99cc-787d28f0c6c4/dev/5671604c-d8e5-4cc9-897f-a8012c635340 failed: exit status 1

This suggests that the losetup command in the minikube iso is still the Busybox one, and not from util-linux. Weird.

Looking into it, kubernetes/minikube#10286 reverted the change... Trying to find out what the problem would be (as building the test iso failed with the revert too).

nixpanic · 2021-03-03T19:51:34Z

kubernetes/minikube#10704 adds losetup from util-linux to the ISO image again... sigh

nixpanic · 2021-04-19T11:16:42Z

@Mergifyio rebase

Signed-off-by: Niels de Vos <ndevos@redhat.com>

mergify · 2021-04-19T11:16:56Z

Command rebase: success

Branch has been successfully rebased

mergify · 2021-04-19T13:30:59Z

This pull request has been merged with the
unsupported configuration option bot_account.

This option will be ignored starting May 1st, 2021, and removed
on June 1st, 2021.

This option can be replaced by update_bot_account, merge_bot_account or both
depending on your use-case (https://docs.mergify.io/actions/merge/).

nixpanic added DNM DO NOT MERGE dependency/k8s depends on Kubernetes features component/testing Additional test cases or CI work labels Jan 22, 2021

nixpanic mentioned this pull request Jan 22, 2021

e2e: add a test case for rbd-nbd mounter #1839

Merged

2 tasks

nixpanic force-pushed the testing/remove-losetup-workaround branch 2 times, most recently from e29d1c2 to 0c8c6c1 Compare January 25, 2021 10:15

nixpanic mentioned this pull request Jan 25, 2021

install losetup from util-linux in the ISO kubernetes/minikube#10255

Merged

nixpanic mentioned this pull request Feb 1, 2021

rebase: update minikube to latest version #1811

Merged

nixpanic force-pushed the testing/remove-losetup-workaround branch from 0c8c6c1 to 335c15a Compare February 10, 2021 15:51

nixpanic marked this pull request as ready for review February 10, 2021 15:51

nixpanic removed the DNM DO NOT MERGE label Feb 10, 2021

nixpanic requested a review from Madhu-1 February 10, 2021 15:52

Madhu-1 reviewed Feb 10, 2021

View reviewed changes

Madhu-1 approved these changes Feb 11, 2021

View reviewed changes

humblec approved these changes Feb 11, 2021

View reviewed changes

Madhu-1 added the DNM DO NOT MERGE label Feb 11, 2021

Base automatically changed from master to devel March 1, 2021 05:22

nixpanic mentioned this pull request Mar 2, 2021

rebase: use minikube v1.18 #1898

Merged

mergify bot pushed a commit that referenced this pull request Mar 3, 2021

rebase: use minikube v1.18

ec691fd

Minikube v1.18 has been released. This conains a fix for our `losetup` workaround, so that can be removed now. Updates: #1840 Signed-off-by: Niels de Vos <ndevos@redhat.com>

nixpanic removed the DNM DO NOT MERGE label Mar 3, 2021

nixpanic mentioned this pull request Apr 11, 2021

rebase: update minikube to version 1.19.0 #1972

Closed

nixpanic mentioned this pull request Apr 19, 2021

rebase: update minikube to version 1.19.0 #1990

Merged

e2e: remove losetup workaround for minikube

2c9696f

Signed-off-by: Niels de Vos <ndevos@redhat.com>

ceph-csi-bot force-pushed the testing/remove-losetup-workaround branch from 335c15a to 2c9696f Compare April 19, 2021 11:16

mergify bot merged commit 27247d1 into ceph:devel Apr 19, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove losetup workaround in minikube VM #1840

Remove losetup workaround in minikube VM #1840

nixpanic commented Jan 22, 2021 •

edited

Loading

nixpanic commented Jan 22, 2021

nixpanic commented Jan 28, 2021

nixpanic commented Feb 1, 2021

Madhu-1 Feb 10, 2021

nixpanic commented Feb 10, 2021 via email

Madhu-1 commented Feb 10, 2021

nixpanic commented Feb 10, 2021

nixpanic commented Feb 11, 2021 •

edited

Loading

nixpanic commented Feb 11, 2021 •

edited

Loading

Madhu-1 commented Feb 11, 2021

nixpanic commented Mar 3, 2021

nixpanic commented Mar 3, 2021

nixpanic commented Mar 3, 2021

nixpanic commented Mar 3, 2021

nixpanic commented Mar 3, 2021

nixpanic commented Apr 19, 2021

mergify bot commented Apr 19, 2021

mergify bot commented Apr 19, 2021

Remove losetup workaround in minikube VM #1840

Remove losetup workaround in minikube VM #1840

Conversation

nixpanic commented Jan 22, 2021 • edited Loading

Describe what this PR does

Related issues

nixpanic commented Jan 22, 2021

nixpanic commented Jan 28, 2021

nixpanic commented Feb 1, 2021

Madhu-1 Feb 10, 2021

Choose a reason for hiding this comment

nixpanic commented Feb 10, 2021 via email

Madhu-1 commented Feb 10, 2021

nixpanic commented Feb 10, 2021

nixpanic commented Feb 11, 2021 • edited Loading

nixpanic commented Feb 11, 2021 • edited Loading

Madhu-1 commented Feb 11, 2021

nixpanic commented Mar 3, 2021

nixpanic commented Mar 3, 2021

nixpanic commented Mar 3, 2021

nixpanic commented Mar 3, 2021

nixpanic commented Mar 3, 2021

nixpanic commented Apr 19, 2021

mergify bot commented Apr 19, 2021

mergify bot commented Apr 19, 2021

nixpanic commented Jan 22, 2021 •

edited

Loading

nixpanic commented Feb 11, 2021 •

edited

Loading

nixpanic commented Feb 11, 2021 •

edited

Loading